Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not export Instruction::appendOperand #1466

Merged
merged 1 commit into from
Jul 26, 2023
Merged

do not export Instruction::appendOperand #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions instructionAPI/h/Instruction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,12 @@ namespace Dyninst


typedef boost::shared_ptr<Instruction> Ptr;
private:
//Should be private, but we're working around some compilers mis-using the 'friend' declaration.
INSTRUCTION_EXPORT void appendOperand(Expression::Ptr e, bool isRead, bool isWritten, bool isImplicit = false, bool trueP = false, bool falseP = false) const;

private:
void updateSize(const unsigned int new_size) {m_size = new_size;}
void decodeOperands() const;
void addSuccessor(Expression::Ptr e, bool isCall, bool isIndirect, bool isConditional, bool isFallthrough, bool isImplicit = false) const;
void appendOperand(Expression::Ptr e, bool isRead, bool isWritten, bool isImplicit = false, bool trueP = false, bool falseP = false) const;
void copyRaw(size_t size, const unsigned char* raw);
Expression::Ptr makeReturnExpression() const;
mutable std::list<Operand> m_Operands;
Expand Down