Hide implementations of complex data structures in SymtabAPI::Symtab #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainest
added
ABI-BREAKER
|
This will have to wait until dyninst/testsuite#233 is merged. |
kupsch
approved these changes
Sep 21, 2023
symtabAPI/h/Symtab.h
Outdated
| @@ -111,6 +91,9 @@ class SYMTAB_EXPORT Symtab : public LookupInterface, | |||
| friend class relocationEntry; | |||
| friend class Object; | |||
|
|
|||
| // Hide implementation details that are complex or add large dependencies | |||
| std::unique_ptr<symtab_impl> impl; | |||
There was a problem hiding this comment.
const std::unique_ptr...? The impl never changes.
There was a problem hiding this comment.
Since Symtab isn't moveable, that is a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to more easily modify the parallelism around the big tables (e.g.,
indexed_modules) without bumping the ABI around, meaning we don't have to wait until a major release to make those changes. This also removes internal details likeconcurrent.hwhich puts TBB into the pubic API and the multiple Boost headers needed formulti_index.Although
ModRangeLookup* mod_lookup();was a public member, it was never documented, and should never be called by a user. I'm not considering this an API-breaking change.