Refactor Symtab::addSymbolToAggregate #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to understand what's happening. It's still not clear why the region check is necessary.
hainest
added
code cleanup
kupsch
approved these changes
Sep 21, 2023
hainest
added a commit
that referenced
this pull request
Sep 28, 2023
A function should only be added to everyFunction if it was not already in funcsByOffset or if it lives in a different code region from the function found with the same offset. This was introduced by #1534.
hainest
added a commit
that referenced
this pull request
Sep 28, 2023
A function should only be added to everyFunction if it was not already in funcsByOffset or if it lives in a different code region from the function found with the same offset. This was introduced by #1534.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to understand what's happening. It's still not clear why the region check is necessary.