Remove DwarfWalker::setModuleFromName #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainest
added
code cleanup
|
I'm an idiot. This shouldn't be checked until #1545 is merged. |
kupsch
approved these changes
Sep 29, 2023
hainest
force-pushed
the
thaines/dwarfwalker_setModuleByName
branch
from
a9fd238
to
1713880
Compare
It's replaced with the updated Symtab::findModuleByOffset. Finding by name was always unnecessary as we know the offset of the current DIE.
hainest
force-pushed
the
thaines/dwarfwalker_setModuleByName
branch
from
1713880
to
5fc7475
Compare
bbiiggppiigg
pushed a commit
that referenced
this pull request
Feb 12, 2024
It's replaced with the updated Symtab::findModuleByOffset. Finding by name was always unnecessary as we know the offset of the current DIE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's replaced with the updated Symtab::findModuleByOffset. Finding by name was always unnecessary as we know the offset of the current DIE.
This is a step toward removing the broken Symtab::findModuleByName.