Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Module::findFunctionByEntryOffset #1561

Merged
merged 1 commit into from Oct 9, 2023

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Oct 6, 2023

This was added by c848409 in 2009, but never implemented. It looks like this was copy/pasted from the earliest Symtab rewrite.

@hainest hainest added code cleanup Bring the code up to modern standards or remove deprecated features Symtab This issue is directly related to SymtabAPI labels Oct 6, 2023
@hainest hainest requested a review from kupsch October 6, 2023 22:10
@hainest hainest self-assigned this Oct 6, 2023
This was added by c848409 in 2009, but never implemented. It looks
like this was copy/pasted from the earliest Symtab rewrite.
@hainest hainest force-pushed the thaines/remove_module_findFunctionByEntryOffset branch from e22c942 to 26a1da5 Compare October 9, 2023 17:20
@hainest hainest merged commit d2d4821 into master Oct 9, 2023
3 checks passed
@hainest hainest deleted the thaines/remove_module_findFunctionByEntryOffset branch October 9, 2023 18:02
bbiiggppiigg pushed a commit that referenced this pull request Feb 12, 2024
This was added by c848409 in 2009, but never implemented. It looks
like this was copy/pasted from the earliest Symtab rewrite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Bring the code up to modern standards or remove deprecated features Symtab This issue is directly related to SymtabAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants