Refactor symtab/Module.h #1573
Merged
Refactor symtab/Module.h #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the sign conversion.
This was just too terrible to leave alone.
hainest
added
code cleanup
kupsch
approved these changes
Oct 11, 2023
bbiiggppiigg
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Move Statement class into its own header/source * Add missing include in RangeLookup.h * Remove redundant visibility specifier in Statement * Use in-class member initializers This removes the sign conversion. * Default the dtor * Whitespace Module.h This was just too terrible to leave alone. * Clean up includes in Module.h * Merge public sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a mess to try and read. It also reduces the size of includes in several places.