Remove DWARFisms from Symtab::Module #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a concept specific to DWARF. These functions are not documented.
There is no need to store the CU DIE from which a Module instance is derived. The address of the CU can be used to reconstitute the entry in the .debug_info section using dwarf_addrdie. Because Module.h is part of the public API for Dyninst, this also removes the transitive dependency on libdw.
hainest
added
ABI-BREAKER
kupsch
approved these changes
Oct 12, 2023
Annoyingly, concurrent.h is in the public header space. Someone could be using it. |
bbiiggppiigg
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Remove compilation directory from Module This is a concept specific to DWARF. These functions are not documented. * Remove DWARFisms from Symtab::Module There is no need to store the CU DIE from which a Module instance is derived. The address of the CU can be used to reconstitute the entry in the .debug_info section using dwarf_addrdie. Because Module.h is part of the public API for Dyninst, this also removes the transitive dependency on libdw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to store the CU DIE from which a Module instance is
derived. The address of the CU can be used to reconstitute the
entry in the .debug_info section using dwarf_addrdie.
Because Module.h is part of the public API for Dyninst, this also
removes the transitive dependency on libdw.