New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move entryIDs into separate data files #1585
Conversation
This will make it much easier to update them as we migrate to Capstone. This is a very poor solution, but is the only means of splitting the architectures apart while maintaining the existing entryID enum usage.
@hainest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but two things
common/h/mnemonics/x86
is missing a NL as its last character- should the names of the file end in
.h
(perhaps_entryIds.h
or_entryId_enums.h
) to indicate that they contain C/C++? This would help with editors and other tools that determine the file type by suffix.
Fixed.
I didn't give them file extensions since they are supposed to be just data files. They also don't contain any valid syntax. EclipseCDT can read them as enum values because it does a full parse when it indexes files, but I guess I was biased by that. Is your editor able to see them like that? |
Vim's syntax highlighting for enum values is the same as text, so hard to tell. Line counting tools like cloc ignore these files without extensions using the default settings. |
I'm not sure but a file extension like .include.h or .include.data |
This gives the reader a better idea of what they are and lets tools like cloc know that they correspond to a language.
@kupsch @bbiiggppiigg I updated the file suffixes. Does that work for you both? |
Looks good. |
Looks good to me. |
This will make it much easier to update them as we migrate to Capstone.
This is a very poor solution, but is the only means of splitting the architectures apart while maintaining the existing entryID enum usage. I tried several different means of making this better, but the only one that worked well requires C++20's
using enum
.@bbiiggppiigg How much effort is it to modify your generator scripts to accommodate the new locations and file formats?