Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove module containment check in Symtab::create{Function,Variable} #1601

Merged
merged 1 commit into from Oct 30, 2023
Merged

Remove module containment check in Symtab::create{Function,Variable} #1601

merged 1 commit into from Oct 30, 2023

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Oct 28, 2023

Having a default module was made a class invariant in 9e85525.

@hainest
Remove module contains check in Symtab::create{Function,Variable}
f9a0c55 
Having a default module was made a class invariant in 9e85525.
@hainest hainest added code cleanup Bring the code up to modern standards or remove deprecated features Symtab This issue is directly related to SymtabAPI labels Oct 28, 2023
@hainest hainest requested a review from kupsch October 28, 2023 05:19
@hainest hainest self-assigned this Oct 28, 2023
@hainest hainest changed the title Remove module contains check in Symtab::create{Function,Variable} Remove module containment check in Symtab::create{Function,Variable} Oct 28, 2023
@hainest hainest merged commit 08dcfab into master Oct 30, 2023
3 checks passed
@hainest hainest deleted the thaines/symtab_create_cleanup branch October 30, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kupsch kupsch kupsch approved these changes

Assignees

@hainest hainest

Labels
code cleanup Bring the code up to modern standards or remove deprecated features Symtab This issue is directly related to SymtabAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hainest @kupsch