Clean up MachRegister class #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is semantically equivalent, but fixes the 'incomplete without default' linter warning.
I don't know if it's correct to assert in these conditions. This is semantically equivalent, fixes the 'incomplete without default' linter warning, and avoids asserting.
This makes them all consisent and fixes the 'incomplete without default' linter warning.
I left the commented-out switch cases. I'm not sure why they aren't used.
It was never implemented.
hainest
added
the
code cleanup
kupsch
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several linter issues with the switches and tidies up some dead code.