Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove locking before calls to convertDebugOffset #1611

Merged
merged 1 commit into from Oct 30, 2023
Merged

Remove locking before calls to convertDebugOffset #1611

merged 1 commit into from Oct 30, 2023

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Oct 30, 2023

It uses a lock internally.

@hainest hainest added the code cleanup Bring the code up to modern standards or remove deprecated features label Oct 30, 2023
@hainest hainest requested a review from kupsch October 30, 2023 12:01
@hainest hainest self-assigned this Oct 30, 2023
@hainest hainest merged commit 135fa2d into master Oct 30, 2023
3 checks passed
@hainest hainest deleted the thaines/remove_convertDebugOffset_locking branch October 30, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kupsch kupsch kupsch approved these changes

Assignees

@hainest hainest

Labels
code cleanup Bring the code up to modern standards or remove deprecated features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hainest @kupsch