Deprecate Symtab::getOrCreateModule #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainest
added
Symtab
hainest
force-pushed
the
thaines/deprecate_symtab_getOrCreateModule
branch
from
1e09fe5
to
fe35179
Compare
|
This trips clang's -Winconsistent-missing-override. Let me go fix that first. |
kupsch
approved these changes
Nov 7, 2023
There are several problems here: 1) Users shouldn't be creating modules 2) When created, the returned module must be "fixed up" before it's useful. There's no need for that when one could be properly constructed at the callsite inside Dyninst. 3) It violates the Single Responsibility Principle
It's private, so can only be used by friends- specifically Object.
The address ranges have already been inserted there by 'addModule'.
hainest
force-pushed
the
thaines/deprecate_symtab_getOrCreateModule
branch
from
fe35179
to
81e3e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several problems here:
Users shouldn't be creating modules
When created, the returned module must be "fixed up" before it's
useful. There's no need for that when one could be properly constructed
at the callsite inside Dyninst.
It violates the Single Responsibility Principle