New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake fixes for Cotie and GCC 4.4 compatibility #164
Conversation
…/fixes/jenkins-fix
Dyninst build finally passing again,
|
I'm actually having weird CMake issues with this after a clean clone/build. I'm not sure why this isn't reflected in the jenkins. |
I appreciate the conditional cotire. Can we also guard this on CMake version? The |
Yup I can add that as well! |
I have tested this on all versions of GCC that the CSL provides. It looks like we need to disable Cotire up to GCC version 4.5.0. Cotire is also disabled if the CMake version isn't at lease 2.8.12. Cotire also only supports GNU, Intel and Clang compilers on Linux. I didn't mess with changing the Cotire configuration for Windows because it looks like the Cotire support for Windows is pretty good. This is ready for a merge whenever someone thinks it's ready. |
@wrwilliams can this be merged in? |
Looks clean to me. Any objections/observed regressions from @cuviper? |
Works for me. |
This will fix build issues on Follis which will fix most of the Jenkins issues right now. This also includes the make install fix #160 and also the
nullptr
compatibility issue #162.