New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various warnings under Visual Studio #169
Conversation
Ping? |
@@ -361,8 +364,8 @@ static struct trap_mapping_header *getStaticTrapMap(unsigned long addr, unsigned | |||
+ curSecn.SizeOfRawData | |||
- 16); | |||
if (0 != strncmp("DYNINST_REWRITE", str, 15)) { | |||
fprintf(stderr, "ERROR IN RTLIB: getStaticTrapMap found bad string [%s] at %lx %s[%d]\n", | |||
str, str, __FILE__,__LINE__); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be [%s] at %p (%s[%d]) to capture the string as a string and as a pointer for debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split off the DynC-enabling fixes (this commit and previous) from the warning cleanup?
dynC split off into #184 |
No description provided.