Fix operand types for vpand #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intel developer manual specifies vpand as having operands "xmm1 xmm2 xmm3/m128". This change reflects this in dyninst.
|
@wrwilliams This is good to go, this is a small correction and it shouldn't cause any issues. |
|
Are there other similar cases in this section of the tables, or was this a lone wolf? |
|
I had a quick look and didn't see anything immediately obvious, although I'm not an x86 expert by any means. |
|
Approved for 9.2.1. We should write up a test that generates a bunch of random bytes and verifies no assertions and all operands are used. |
|
@wrwilliams Sorry I forgot to get back to you on this. I remember I had to add this instruction by hand and it was just a simple typo. There shouldn't be any other issues related to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intel developer manual specifies vpand as having operands "xmm1 xmm2
xmm3/m128". This change reflects this in dyninst.