Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linemaps for CUBINs #516

Merged
merged 4 commits into from Jan 15, 2019
Merged

Fix linemaps for CUBINs #516

merged 4 commits into from Jan 15, 2019

Conversation

jmellorcrummey
Copy link
Contributor

This pull request fixes two things

  1. In parseLineInfoForObject, the test of (!li_for_object) was inverted.
  2. All CUBINs must use parseLineInfoForObject rather than iterating through compilation units using parseLineInfoForCU. We have encountered CUBINs assembled by nvlink that have information about some compilation units but not others because some compilation units were compiled with -G and others were compiled with only --generate-line-info. The only safe way to read line map information for CUBINs is parseLineInfoForObject.

@Jokeren this pull request contains the changes that you need.

@mxz297 mxz297 merged commit 93e2591 into dyninst:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmellorcrummey @mxz297