Attempts to fix legacy test failures in Dyninst test suite #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test1_22 failures in rewriter mode is fixed. |
|
pc_tls failures should be fixed with this branch and a new commit pushed to the test suite |
|
test_pt_ls failed due to the directory layout change of dyninst installation. |
|
power_decode failed due to recycled & updated opcodes (in other words, the test was wrong). |
|
@hainest Can you pull the current test suite and this branch and give it a run on your machine? Now there should be no test failures at all on x86-64. |
|
@mxz297 When you get a chance, could you rebase this on master? |
it does not check whether this library has been loaded before or not. Dyninst will create multiple binaryEdit objects for one library, which can cause inconsistent states between these objects. This fix adds a map to BPatch_binaryEdit to make sure each library is only loaded once.
The root cause is a broken library name matching code. Just should boost:filesystem::path to deal with file paths.
mxz297
force-pushed
the
known_test_failures_fixes
branch
from
dce4af9
to
027accb
Compare
|
@hainest rebased. |
hainest
added
bug
test suite
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix test failures listed in #550.