New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad interactions between patchAPI and parseAPI #564
Conversation
@hainest Ready to test |
See #560 for details. |
This seems to tickle the hang bug. I had to run it three times on x86 to get it to complete before the watchdog killed it. There were no regressions on x86, though (I'm still testing ARM). |
The following regressions are seen on ARM with respect to the head of master. The last 8 have been seen with other PRs, and are likely non-deterministic failures. test1_21,gcc,none,64,attach,NA,dynamic,PIC,FAILED test5_1,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED |
I just had a testsuite run on leela. The above failures does not happen, but I got a hang on test_thread_6, with a different hang scenario that I encountered on ppcle.... |
new block in parse_data
Currently the default is 32-bit. Change the default to 64-bit
represents the number of bytes to access if reading/writing with this snippet. API compatibility is maintained by setting the default value of the seoncd parameter to 8 (bytes)
The PR is rebased and under testing. |
No regressions on x86, power or ARM. |
The general problem is that when users use patchAPI to modify CFG, some of the modification is not properly updated in parseAPI data structures.