Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad interactions between patchAPI and parseAPI #564

Merged
merged 3 commits into from May 12, 2019
Merged

Conversation

mxz297
Copy link
Member

@mxz297 mxz297 commented Mar 5, 2019

The general problem is that when users use patchAPI to modify CFG, some of the modification is not properly updated in parseAPI data structures.

@mxz297
Copy link
Member Author

mxz297 commented Mar 15, 2019

@hainest Ready to test

@hainest
Copy link
Contributor

hainest commented Mar 15, 2019

See #560 for details.

@hainest
Copy link
Contributor

hainest commented Mar 15, 2019

This seems to tickle the hang bug. I had to run it three times on x86 to get it to complete before the watchdog killed it. There were no regressions on x86, though (I'm still testing ARM).

@hainest
Copy link
Contributor

hainest commented Mar 15, 2019

The following regressions are seen on ARM with respect to the head of master. The last 8 have been seen with other PRs, and are likely non-deterministic failures.

test1_21,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_22,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_24,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_28,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_30,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test2_13,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test2_7,gcc,none,64,attach,NA,dynamic,PIC,FAILED

test5_1,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED
test5_2,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED
test5_3,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED
test5_4,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED
test5_5,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED
test5_7,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED
test5_8,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED
test5_9,g++,none,64,rewriter,NA,dynamic,nonPIC,CRASHED

@mxz297
Copy link
Member Author

mxz297 commented Mar 19, 2019

The following regressions are seen on ARM with respect to the head of master. The last 8 have been seen with other PRs, and are likely non-deterministic failures.

test1_21,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_22,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_24,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_28,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test1_30,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test2_13,gcc,none,64,attach,NA,dynamic,PIC,FAILED
test2_7,gcc,none,64,attach,NA,dynamic,PIC,FAILED

I just had a testsuite run on leela. The above failures does not happen, but I got a hang on test_thread_6, with a different hang scenario that I encountered on ppcle....

@mxz297 mxz297 added the ongoing Flags when someone is working on it but it's paused for some reason, such as waiting for a feedback. label May 2, 2019
Currently the default is 32-bit. Change the default to 64-bit
represents the number of bytes to access if reading/writing with this
snippet.

API compatibility is maintained by setting the default value of the
seoncd parameter to 8 (bytes)
@mxz297 mxz297 removed the ongoing Flags when someone is working on it but it's paused for some reason, such as waiting for a feedback. label May 12, 2019
@mxz297
Copy link
Member Author

mxz297 commented May 12, 2019

The PR is rebased and under testing.

@mxz297
Copy link
Member Author

mxz297 commented May 12, 2019

No regressions on x86, power or ARM.

@mxz297 mxz297 merged commit 1e1b18e into master May 12, 2019
@mxz297 mxz297 deleted the patch_cfg branch May 12, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants