Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost cleanup #578

Merged
merged 57 commits into from May 2, 2019
Merged

Boost cleanup #578

merged 57 commits into from May 2, 2019

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Apr 4, 2019 •
edited

This substantially changes how we handle Boost builds in Dyninst. The goal is to have a coherent Boost build between Dyninst and Testsuite.

Notable changes:

  1. Tagged build layouts are now fully supported
  2. Boost is exported to the same install structure as Dyninst (fixes Make boost available after 'make install' #563)
  3. All cmake variables that control Boost's build options are now available for the user to change via cache variables (e.g., -DBoost_USE_MULTITHREADED)
  4. Substantial error handling has been added
  5. Consolidates all Boost-related activities into cmake/Boost.cmake
  6. Makes Boost-1.61 the new minimum version (needed for Filesystem)
  7. Builds Boost-1.69 when building from source

@hainest
Clean up cmake Boost handling
a416d21 
Fixes #563
@hainest
Copy cmake files on install
f3ca081
@hainest
Remove unused BOOST_BASE
5ac470d
@hainest
Make BOOST_MIN_VERSION a cache variable
4d2b7a6
@hainest
Add FindBoost from cmake 3.14
481cde7 
This is needed to support the newest tagged layout formats from Boost.
@hainest
Make Boost_XXX variables cache variables
01806a8 
Some of these variables control the tagged layout structure used in
FindBoost, so they need to be modifiable by the user.
@hainest
Update comments
c8e3d2f
@hainest
Remove Boost_ADDITIONAL_VERSIONS
3217503 
The latest version of FindBoost will search all versions since
BOOST_MIN_VERSION.
@hainest
Always disable Boost's cmake
00adfc1
@hainest
Copy CMakeCache.txt into INSTALL_CMAKE_DIR
523dcb6
@hainest
Change directory to file for CMakeCache.txt
42965a1
@hainest
Only use Boost multithreading if Boost_USE_MULTITHREADING is enabled
ab0609a
@hainest
Check Boost_USE_STATIC_RUNTIME when doing Boost source build
22b3054
@hainest
Rename Boost_USE_MULTITHREADING -> Boost_USE_MULTITHREADED
c285952
@hainest
Copy link
Contributor Author

hainest commented Apr 4, 2019

Passing on x86, ARM (Leela), and Power9.

@sashanicolas could you test on Kachina to see if this resolves the Boost build issues you were experiencing?

@hainest
Copy link
Contributor Author

hainest commented Apr 4, 2019

"Passing" meaning building successfully. I can't test with the Testsuite until I change the Boost building there, as well.

@hainest
Use correct types for cache variables
a231326
@hainest
Save library file location cache entries when building from source
ad982cb
@hainest
Add Boost::Chrono library
2326323
@hainest
Move defines to Boost.defines.cmake
7b5c75e
@hainest
Rename Boost.defines.cmake to module BoostDefines.cmake
2a7c2ee
@hainest
Set windows library extension to 'dll' when building from source
0774cca
@hainest
Set CMAKE_MODULE_PATH before importing any other modules
643cc94
@hainest
Add ${DYNINST_ROOT}/cmake to module path
151381b
@hainest
Include Boost wrapper as module instead of file
341de24
@hainest
Use WIN32 instead of MSVC to detect Windows
b2e7f0b 
MSVC only detects that the MSVC compiler is being used.
@hainest
Find Threads package instead of erroring out
b556a8c
@hainest
Fix capitalization of ExternalProject_Add
636c8f6
@hainest
Export Boost_THREAD_LIBRARY when building from source
789e95e
@hainest
Change Boost_COMPONENTS to an internal variable
25bb56a
@hainest hainest added enhancement test suite These changes are needed to correct or improve a test in the Testsuite. v10.1-release labels Apr 17, 2019
@hainest
Make BOOST_ROOT a CMake cache variable
90df88b
@hainest
Always export Boost_THREAD_LIBRARY
9199ac2
@hainest
Add detailed instructions for Boost module
7e32fa4
@hainest
Clean up formatting
4561463
@hainest
Add hard minimum version check
f9847df
@hainest
Correctly build list of Boost libraries when building from source
e1a7d84
@hainest
Export Boost_LIBRARIES
de711ee
@hainest
Export variables immediately instead of delaying to the end
0d7fd10 
This makes the process more uniform.
@hainest
Update comments
ef7eec2
@hainest
Add dummy target when not building from source
65fc46f
@hainest
Add cotire support
e3b8f1b
@hainest
Change comment region decoration
df33425 
This prevents cmake-format from removing them.
@hainest
Canonicalize all user-defined and exported Boost variables
79a1f12
@hainest
Consistently layout the comment header
bd576ac
@hainest
Rename Boost_ROOT to Boost_ROOT_DIR
1412ae8
@hainest
Don't save the Boost hint directories in the cache
d8dbd36
@hainest
Update hint directory comments
c892d56
@hainest
Complete list of exported variables
8a14f55
@hainest
Fix _boost_min_version comments
332e03d
@hainest
Default Boost_ROOT_DIR using PATH_BOOST
999d8d8
@hainest
Build Boost_MIN_VERSION from source, if specified
bdbd5d0 
If the user specified a version of Boost that is not the default
download version, then use that version, instead.
@hainest
Canonicalize internal names as _boost_XX
94a9b55
@hainest
Add clarifying comments for Boost download version check
f984520
@hainest hainest mentioned this pull request Apr 29, 2019
Merged
@hainest hainest merged commit c6c4c04 into dyninst:master May 2, 2019
hainest added a commit to dyninst/testsuite that referenced this pull request May 2, 2019
@hainest
Build cleanup (#50)
2d52621 
Fixes #46 
Fixes #39 
Fixes #38 
Fixes #36

Integrates the changes reflected in

dyninst/dyninst#584
dyninst/dyninst#578
dyninst/dyninst#591
@hainest hainest deleted the boost_cleanup branch May 10, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hainest hainest

Labels
bug enhancement test suite These changes are needed to correct or improve a test in the Testsuite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make boost available after 'make install'
1 participant
@hainest