test_thread_1 cleanup #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the Dyninst lock's usage mirrors the pthread lock's usage exactly.
This makes it much clearer as to what's happening.
This can't be run there.
There's no need for all of the casting.
The current flag-based implementation isn't thread-safe. It's also not needed as joining serves the same purpose (i.e., detecting that all threads are done running).
dlerror() wouldn't work when called after some other successful call to dlsym.
Having threads write into adjacent elements of an array can cause spurious _successes_ even when the Dyninst lock fails to work correctly. Using an atomic removes this possibility.
hainest
force-pushed
the
test_thread_1_cleanup
branch
from
46b9286
to
69aae23
Compare
kupsch
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a complete re-write of this test.