Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RI-136: archive une offre #167

Merged
merged 4 commits into from
Nov 16, 2021
Merged

RI-136: archive une offre #167

merged 4 commits into from
Nov 16, 2021

Conversation

mathusha-sdv
Copy link
Contributor

@mathusha-sdv mathusha-sdv commented Nov 9, 2021 •
edited
Loading

  • tests
  • Route pour archiver les offres

@mathusha-sdv mathusha-sdv self-assigned this Nov 9, 2021
@mathusha-sdv mathusha-sdv added this to In progress in implicaction via automation Nov 9, 2021
matthieuaudemard
matthieuaudemard requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@matthieuaudemard matthieuaudemard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai proposé une simplification en passant par le champ archive du modèle Job.

Il faudrait que tu délimites tes tests comme je l'ai fait en mode

// given
...
// when
...
// then

pour plus de lisibilité, sinon c'est vite le bordel 😆

Mais gg quand même et merci pour les test 👍

...ction/src/main/java/com/dynonuggets/refonteimplicaction/controller/JobPostingController.java Outdated Show resolved Hide resolved
...licaction/src/main/java/com/dynonuggets/refonteimplicaction/repository/StatusRepository.java Outdated Show resolved Hide resolved
...mplicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/JobPostingService.java Outdated Show resolved Hide resolved
...mplicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/JobPostingService.java Outdated Show resolved Hide resolved
...mplicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/JobPostingService.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
...licaction/src/main/java/com/dynonuggets/refonteimplicaction/repository/StatusRepository.java Outdated Show resolved Hide resolved
implicaction automation moved this from In progress to Review in progress Nov 11, 2021
matthieuaudemard
matthieuaudemard requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@matthieuaudemard matthieuaudemard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍

  • les tests sont très bien (j'ai juste laissé une petite remarque pour une amélioration et un peu de code style à corriger)
  • le périmètre est super géré 🥳 et c'est un plaisir de corriger un petite PR comme ça

image

.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java Outdated Show resolved Hide resolved
data.sql Outdated Show resolved Hide resolved
@mathusha-sdv mathusha-sdv changed the title RI-136: Archivage d'un job RI-136: archive une offre Nov 15, 2021
implicaction automation moved this from Review in progress to Reviewer approved Nov 16, 2021
@mathusha-sdv mathusha-sdv merged commit fc0c639 into develop Nov 16, 2021
implicaction automation moved this from Reviewer approved to Done Nov 16, 2021
@mathusha-sdv mathusha-sdv deleted the RI-136 branch November 16, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieuaudemard matthieuaudemard matthieuaudemard approved these changes

@PaFlu-SDV PaFlu-SDV Awaiting requested review from PaFlu-SDV

Assignees

@mathusha-sdv mathusha-sdv

Labels
back jobs
Projects
implicaction
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathusha-sdv @matthieuaudemard @nekorpeche