-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RI-139: [admin/job] permet l'archivage de plusieurs offres #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieuaudemard
requested changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il faudra :
- modifier le controller pour qu'il reçoive une liste de jobIds
- créer une méthode ds le service qui prend une liste de jobIds et change l'attribut archive de chaque élément
- mettre à jour les tests
...ction/src/main/java/com/dynonuggets/refonteimplicaction/controller/JobPostingController.java
Outdated
Show resolved
Hide resolved
...ction/src/main/java/com/dynonuggets/refonteimplicaction/controller/JobPostingController.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Show resolved
Hide resolved
* tests
* fix d'un oubli au niveau de l'archivage * tests
* code review * tests non fonctionnels
* code review * test non fonctionnels
matthieuaudemard
requested changes
Nov 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas mal, j'ai laissé quelques commentaires qui devrait te permettre de faire passer les tests
...mplicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/JobPostingService.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/dynonuggets/refonteimplicaction/controller/JobsPostingControllerTest.java
Outdated
Show resolved
Hide resolved
* faire passer les tests * j'ai ajouté le champ archive au niveau de l'adapteur
matthieuaudemard
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
le test archiveJobShouldChangeListStatus ne fonctionne pas, quand j'envoie mes données, l'API me renvoie un body null