Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RI-139: [admin/job] permet l'archivage de plusieurs offres #184

Merged
merged 8 commits into from
Nov 22, 2021

Conversation

mathusha-sdv
Copy link
Contributor

@mathusha-sdv mathusha-sdv commented Nov 18, 2021

le test archiveJobShouldChangeListStatus ne fonctionne pas, quand j'envoie mes données, l'API me renvoie un body null

@mathusha-sdv mathusha-sdv added this to In progress in implicaction via automation Nov 18, 2021
@mathusha-sdv mathusha-sdv self-assigned this Nov 18, 2021
Copy link
Member

@matthieuaudemard matthieuaudemard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudra :

  • modifier le controller pour qu'il reçoive une liste de jobIds
  • créer une méthode ds le service qui prend une liste de jobIds et change l'attribut archive de chaque élément
  • mettre à jour les tests

implicaction automation moved this from In progress to Review in progress Nov 19, 2021
@matthieuaudemard matthieuaudemard changed the title RI-139: Archive plusieurs offres RI-139: [amdin/job] permet l'archivage de plusieurs offres Nov 19, 2021
@matthieuaudemard matthieuaudemard changed the title RI-139: [amdin/job] permet l'archivage de plusieurs offres RI-139: [admin/job] permet l'archivage de plusieurs offres Nov 19, 2021
* code review
* test non fonctionnels
Copy link
Member

@matthieuaudemard matthieuaudemard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas mal, j'ai laissé quelques commentaires qui devrait te permettre de faire passer les tests

nekorpeche and others added 2 commits November 22, 2021 20:15
* faire passer les tests
* j'ai ajouté le champ archive au niveau de l'adapteur
implicaction automation moved this from Review in progress to Reviewer approved Nov 22, 2021
@mathusha-sdv mathusha-sdv merged commit 333649f into develop Nov 22, 2021
implicaction automation moved this from Reviewer approved to Done Nov 22, 2021
@mathusha-sdv mathusha-sdv deleted the RI-139 branch November 22, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants