RI-203: permet de valider une offre et un groupe #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mathusha-sdv
commented
Dec 8, 2021
mathusha-sdv
commented
- la validation des offres fonctionne
- problème quand j'utilise deux paginate dans une même page, le paginate.content est le même pour les deux. Ils récupèrent d'abord l'utilisateur puis les offres du coup ça ne s'affiche pas correctment
|
J'ai ajouté des tests :) la validation fonctionne mais dès que j'essaie de récupérer le champ utilisateur du groupe ça casse tout :/ |
matthieuaudemard
requested changes
Dec 11, 2021
...implicaction/src/main/java/com/dynonuggets/refonteimplicaction/adapter/SubredditAdapter.java
Outdated
Show resolved
Hide resolved
...plicaction/src/main/java/com/dynonuggets/refonteimplicaction/controller/GroupController.java
Outdated
Show resolved
Hide resolved
...plicaction/src/main/java/com/dynonuggets/refonteimplicaction/controller/GroupController.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/dynonuggets/refonteimplicaction/repository/JobPostingRepositoryCustom.java
Outdated
Show resolved
Hide resolved
...implicaction/src/test/java/com/dynonuggets/refonteimplicaction/adapter/GroupAdapterTest.java
Show resolved
Hide resolved
...-implicaction/src/app/admin/jobs/components/pending-job-table/pending-job-table.component.ts
Outdated
Show resolved
Hide resolved
...-implicaction/src/app/admin/jobs/components/pending-job-table/pending-job-table.component.ts
Outdated
Show resolved
Hide resolved
matthieuaudemard
requested changes
Dec 11, 2021
frontend-implicaction/src/app/core/services/api-endpoints.service.ts
Outdated
Show resolved
Hide resolved
matthieuaudemard
requested changes
Dec 11, 2021
backend-implicaction/src/main/java/com/dynonuggets/refonteimplicaction/utils/ApiUrls.java
Outdated
Show resolved
Hide resolved
frontend-implicaction/src/app/admin/groups/pending-group-table/pending-group-table.component.ts
Outdated
Show resolved
Hide resolved
...-implicaction/src/app/admin/jobs/components/pending-job-table/pending-job-table.component.ts
Outdated
Show resolved
Hide resolved
* la validation des offres fonctionne * problème quand j'utilise deux paginate dans une même page, le paginate.content est le même pour les deux. Ils récupèrent d'abord l'utilisateur puis les offres du coup ça ne s'affiche pas correctment
* la validation des offres fonctionne * problème quand j'utilise deux paginate dans une même page, le paginate.content est le même pour les deux. Ils récupèrent d'abord l'utilisateur puis les offres du coup ça ne s'affiche pas correctment
* fix du BasePageableWithCriteria
* probèle quand j'essaie d'ajouter l'utilisateur au groupe, j'ai retiré le bout de code qui me le permettait et générait l'erreur
* code review
* code review
* code review
Comment on lines
97
to
98
| static readonly ACTIVATE_GROUP = 'groups/activate'; | ||
| static readonly VALIDATE_GROUP = 'groups/validate'; |
There was a problem hiding this comment.
C'est quoi du coup la différence entre les 2 ?
There was a problem hiding this comment.
un vestige du rebase !
There was a problem hiding this comment.
Du coup pour moi tu peux merge dès que les tests sont passés
matthieuaudemard
approved these changes
Dec 11, 2021
* code obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.