fix: transpose selected region correctly #397 #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On wayland, window and screen dimensions reported by Qt differ if "normal" scaling is used, or the experimental fractional scaling (scale-monitor-framebuffer). To transpose the selected region from window position to screenshot position robustly, it's better to use Qt's window dimensions as reference instead of the Qt's screen dimensions.
dynobo
force-pushed
the
feature/fix-selection-with-scaling
branch
from
f9d3615
to
9768788
Compare
dynobo
force-pushed
the
feature/fix-selection-with-scaling
branch
from
9768788
to
eb6bec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On wayland, window and screen dimensions reported by Qt differ if "normal" scaling is used, or the experimental fractional scaling (scale-monitor-framebuffer). To transpose the selected region from window position to screenshot position robustly, it's better to use Qt's window dimensions as reference instead of the Qt's screen dimensions.