Add support for bug table and data in .bss sections #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow bundling of .bss.* sections that are the result of -fdata-sections so that rela sections referencing data in bss sections by section symbol can be replaced with the object symbol so it can be linked to the existing data object in the kernel. Signed-off-by: Seth Jennings <sjenning@redhat.com>
The section header size is calculated at output time by libelf and we use it as a read-only value from read files. With the next patch we are changing the size of the .rela__bug_table section. Lets use d_size instead since it is the value that tells libelf how to calculate sh_size at output time. Signed-off-by: Seth Jennings <sjenning@redhat.com>
This commit adds a new function to properly handle the bug table. It works by going through .rela__bug_table, after the changed function symbols have already been marked, and rewrites the section including only the relocations pertaining to bug entries for changed functions. The __bug_table section itself is not modified resulting in "blank" bug entries: ones whose IP and filename pointers will not be relocated and, therefore, will be zero. While a waste of space, it simplifies the code not to remove these blank entries. They do no harm. Signed-off-by: Seth Jennings <sjenning@redhat.com>
While debugging the code for the bug table logic, I found it useful to know which rela section and entry the error occurred on. Signed-off-by: Seth Jennings <sjenning@redhat.com>
|
I haven't done a great deal of regression testing on this yet, but wanted to get the code out there for review (and backup) before I signed out for the evening. @jpoimboe don't merge until I can run a few tests. I'll let you know. |
Signed-off-by: Seth Jennings <sjenning@redhat.com>
|
New commit addresses all comments thus far. |
|
@jpoimboe I have done my testing and everything looks good. If it looks good to you, feel free to merge it. |
jpoimboe
added a commit
that referenced
this pull request
Apr 22, 2014
Add support for bug table and data in .bss sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.