kpatch: a few minor script cleanups #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of "kpatch unload --all", just show the usage help instead of this: # kpatch unload --all basename: unrecognized option '--all' Try 'basename --help' for more information. unloading patch module: basename: unrecognized option '--all' Try 'basename --help' for more information. rmmod: ERROR: Module is builtin. kpatch: failed to unload patch --all
Try to be more consistent with the naming of patch modules. They are patch modules, where patch is the adjective and module is the noun. So calling them patches is confusing.
|
Agreed, that it should be a separate commit. And I know this fixes a bug we have so, I'm ok with it for now and we can look into possibly changing the CLI. |
sjenning
added a commit
that referenced
this pull request
Jun 3, 2014
kpatch: a few minor script cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.