Fixes for symbol collisions in add-patches-section and cleanup #55
Conversation
|
I think this would be a good case for adding an additional test for the test suite. Should we use a separate PR for that? |
|
Yes, I should write a testcase for this. I'll get on that as a separate PR when I get back. |
|
So github doesn't seem to be showing commit comments in PRs any more, which is really confusing me. Not sure what's up with that. I'm not sure if you saw my comment, but it had to do with the "add file hint to link-vmlinux-syms" commit. Line 260 guarantees that the symbol is global, but line 274 is doing file hinting which doesn't make sense for a global symbol. I don't know which line is wrong, but I think there's a discrepancy there. |
|
Yes, I saw it and agree. I think the limiting to global symbols of the wrong part, not the hint. I need to look at it closer. I will on Monday. Thanks for the review! |
|
Sounds good, I'm out. Have a good weekend :-) |
Currently, add-patches-section just blindly looks in vmlinux for a function symbol matching the name of the patched function in the input object file. However, for local symbols, they may appear multiple times in the vmlinux symbol table since the symbol name may be reused locally in different files. This commit add support for "file hinting". It tracks what file the symbol is in and searches for local symbols within that file in vmlinux first. If it doesn't find one, it then searches globally like it always has. Fixes issue #53 Signed-off-by: Seth Jennings <sjenning@redhat.com>
Signed-off-by: Seth Jennings <sjenning@redhat.com>
Signed-off-by: Seth Jennings <sjenning@redhat.com>
Signed-off-by: Seth Jennings <sjenning@redhat.com>
sjenning
changed the title
Fixes for symbol collisions in add-patches-section and cleanup
Plus some cleanups and adding a TODO