Fix build problem with latest Racket release (aka fix the "x undefined" error) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the undefined value
…oduced reset-make-label-counter to do so.
add support for on-release in big-bang
Update whalesong's image library
FIX broken standalone build by ditching XHTML in favor of HTML #17
Update README for changed standalone build argument
Implement place-images* functions in image library
support (-360,360) angles for whalesong/image rotate
whalesong/image rotate accepts any real num
FIX: fix stop-when without last-picture crash in world #23
Returning stop-with from any big-bang handler, ends the world and renders the last-picture
So that we could push out types.rkt from outer world.rkt file.
Implement stop-with #23
NOTE: Workaround until pinhole is properly supported
FIX: Check for undefined pinholes in place-image/align #28
Implement underlay/offset, overlay/offset and empty-image
Reverted patch, added success handler to end of call stack, which is not getting called. We already have separate handlers for error, so we might as well have one for success explicitely. This reverts commit 0428a02. Conflicts: whalesong/js-assembler/assemble.rkt whalesong/js-assembler/runtime-src/runtime.js
Revert "trying to get rid of the current success handler." FIXES #34
That function is moving from `unstable/sequence` to `racket/sequence`. Inlining it preserves backwards compatibility while removing the dependency on unstable.
Inline definition of `in-syntax`.
This is important for the get-javascript command, which outputs the result to stdout. In order for this to be useful, it can be redirected to a file, but if reporting information also goes to stdout, then it ends up in the resulting JavaScript. Switching these messages to stderr prevents that problem.
Set the reporting port to the error port by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of Racket has introduced an "undefined" value.
If the undefined value is referenced an exception is thrown.
This affects letrec, which no longer allows the (letrec ((x x)) x) trick that occurs
in the Whalesong song source, where an undefined value is needed.
A temporary fix is to redefine letrec and letrec-values to use the old semantics.
This PR does just that.
A longer term fix would be to introduce a new type of runtime value to represent
the undefined value.