-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chapter-make-read.lua: adding and writing chapters works, but loading fails at mpv start in command line. #3
Comments
Yes,these are mpv builtins(defaults.lua; options.lua). |
mpv was started with these arguments:
The log is at the end. It says chapter_make_read.conf not found.. Well ... yes, this file is missing. It's because the README mentioned it and pointed to more detailed info in the script itself, but there I could not find that information (or I did not understand it correctly). To my understanding, it looks like I don't need it as long as the options in
Are OK for me. I only added two key bindings to input.conf: I omitted the write_xml binding because I dont't need it for now. And now the log: mpv log
|
I don't see any errors in your log, please make sure there are external chapter file with name is |
I found that this was due to the script of chapter-make-read.lua is failure to properly handle the relative path, and fixed it in the latest commit of 2fb99a6. |
Yes, it works. Thank you very much. Would you mind if I edit the title of this issue to: I think it would be more appropriate now that I learned that the required modules are mpv builtins. |
Hi,
I just found your script collection and tried to use chapter-make-read.lua.
Creating chapters and writing the file works, but when I close and restart mpv, the chapters file isn't imported. I assume it's because I don't have 'mp.msg', 'mp.utils', and "mp.options" which are listed as "required" in your script (unless they're mpv builtins).
However, I could not found any info if they are mpv builtins and if not where to get them.
I think that for users who are not very experienced with lua scripts, it would be helpful to add a little bit of explanation in the README.
Thanks, Markus
The text was updated successfully, but these errors were encountered: