Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: k8s-agent deployment update #245

Closed
nandor-magyar opened this issue Oct 7, 2022 · 3 comments
Closed

Refactor: k8s-agent deployment update #245

nandor-magyar opened this issue Oct 7, 2022 · 3 comments
Labels
issue:enhancement New feature or request issue:hacktoberfest Issue marked as suitable for Hacktoberfest lang:k8s-manifest source:agent The scope of the issue or pull request is agent.

Comments

@nandor-magyar
Copy link
Contributor

nandor-magyar commented Oct 7, 2022 •
edited

The original task is split into two, this is the second half.
The other part: #244

You are going to need a cluster to develop this feature & test it, that can be done locally: kind or minikube.

Folder of k8s manifests:
https://github.com/dyrector-io/dyrectorio/tree/develop/agent/manifest/kubernetes

TODO:

  • Extend the deployment manifest with an init-container, using the same image, receiving the config map, but having an extra init argument
  • Test

Using the cli, you can start the application fairly easy and can test if it is working.

Expected behavior:

  • Setup a k8s node in dyrectorio
  • apply your local version of the updated manifest using kubectl
  • it should start, connect normally
  • create a simple product
  • creating a deployment targeting your node you can provide secrets
@nandor-magyar nandor-magyar added issue:enhancement New feature or request source:agent The scope of the issue or pull request is agent. issue:hacktoberfest Issue marked as suitable for Hacktoberfest lang:k8s-manifest labels Oct 7, 2022
@minhoryang
Copy link
Contributor

I'll dive in this.

minhoryang pushed a commit to minhoryang/dyrectorio that referenced this issue Oct 27, 2022
@minho-comcom-ai
feat(agent): dyrector-io#245, crane init at k8s deployment for shared…
8b17631 
… secret
@minhoryang
Copy link
Contributor

I'll make a PR after #293 merged.

minhoryang added a commit to minhoryang/dyrectorio that referenced this issue Oct 28, 2022
@minhoryang
feat(agent): dyrector-io#245, crane init at k8s deployment for shared…
e8ef016 
… secret
@minhoryang minhoryang mentioned this issue Oct 28, 2022
Merged
minhoryang added a commit to minhoryang/dyrectorio that referenced this issue Oct 30, 2022
@minhoryang
feat(agent): dyrector-io#245, crane init at k8s deployment for shared…
e64fc30 
… secret
polaroi8d pushed a commit that referenced this issue Oct 31, 2022
@minhoryang
feat(agent): #245, crane init at k8s deployment for shared secret (#307)
41725f8
@minhoryang
Copy link
Contributor

merged.

balanceee pushed a commit that referenced this issue Nov 2, 2022
@minhoryang @balanceee
feat(agent): #245, crane init at k8s deployment for shared secret (#307)
354cf75
balanceee pushed a commit that referenced this issue Nov 2, 2022
@minhoryang @balanceee
feat(agent): #245, crane init at k8s deployment for shared secret (#307)
0dcb0b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue:enhancement New feature or request issue:hacktoberfest Issue marked as suitable for Hacktoberfest lang:k8s-manifest source:agent The scope of the issue or pull request is agent.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@minhoryang @polaroi8d @nandor-magyar