-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dagent resource management #589
Comments
Hi, pls assign this issue to me ;) |
Assigned to you, @AmorfEvo. If you have any questions don't hesitate to ask the team 🖖🏻 |
Thx. I want to figure it out from zero to 1, but if I have any questions I'll ask them ^^ @polaroi8d |
Dear #Hacktoberfest, this task is still open 😄 |
Hi @polaroi8d , I have a few questions related to this. Kubernetes also has a scheduler for resource limits and resource requests, why only for the docker? Is there any specific reason for that? I don't have enough hands-on experience in Kubernetes as well. It would be great if you explain about this such that I could start over from zero |
Hello @chandhuDev are you still working on this issue ? I figured out the golang changes for the builder , dagent and proto? Would you like to pair on it ? @polaroi8d what do you think, should i continue. If yes i have some questions . |
As response to @chandhuDev questions, a summary: we already have Kubernetes integration of resource management in-place, but for docker, this is less used, may be less practical and a bit hidden. The docker part is missing from our builder, that is what we seek to implement here. These information should be enough to start effectively working on it. |
I implemented the docker part here. |
We ignored this since it may not have a significant impact, but it would be nice to have and not too complicated to implement.
Compared to Kubernetes, resource requests don't really make sense for us because we don't need to instruct the scheduler since it doesn't exist. However, Docker does have CPU and memory limits.
Affected scope:
Please provide a test case in golang as well.
Additional information: Our platform backend is built with Node.js called
crux
, and the UI built with React is calledcrux-ui
.The text was updated successfully, but these errors were encountered: