Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: product templates #243

Merged
merged 15 commits into from Oct 25, 2022
Merged

feat: product templates #243

merged 15 commits into from Oct 25, 2022

Conversation

robot9706
Copy link
Contributor

Agent:

  • Traefik conflicted with custom network names - both works now
  • Added Traefik ports to config

Crux:

  • Added templates which can be defined using JSON
  • Added Strapi (with Postgres) template

@robot9706 robot9706 self-assigned this Oct 7, 2022
@robot9706 robot9706 added source:web The scope of the issue or pull request is web. pr:feat lang:golang lang:typescript source:agent The scope of the issue or pull request is agent. labels Oct 7, 2022
@robot9706 robot9706 requested a review from a team October 7, 2022 09:25
@robot9706 robot9706 marked this pull request as ready for review October 7, 2022 09:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 13.56% // Head: 13.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0a94281) compared to base (7c2471b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #243   +/-   ##
========================================
  Coverage    13.56%   13.56%           
========================================
  Files           51       51           
  Lines         4828     4827    -1     
========================================
  Hits           655      655           
+ Misses        4151     4150    -1     
  Partials        22       22           
Impacted Files Coverage Δ
golang/pkg/dagent/dagent.go 0.00% <0.00%> (ø)
golang/pkg/dagent/utils/container.go 0.00% <0.00%> (ø)
golang/pkg/dagent/utils/docker.go 12.25% <0.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

web/crux-ui/locales/en/templates.json Outdated Show resolved Hide resolved
web/crux-ui/src/components/main/sidebar.tsx Outdated Show resolved Hide resolved
web/crux/proto/crux.proto Outdated Show resolved Hide resolved
web/crux/proto/crux.proto Outdated Show resolved Hide resolved
web/crux/templates/strapi.json Outdated Show resolved Hide resolved
web/crux/templates/strapi.json Outdated Show resolved Hide resolved
web/crux/src/services/template.file.service.ts Outdated Show resolved Hide resolved
web/crux-ui/src/validations/template.ts Outdated Show resolved Hide resolved
@robot9706 robot9706 marked this pull request as draft October 18, 2022 13:17
@robot9706 robot9706 marked this pull request as ready for review October 19, 2022 08:50
@polaroi8d
Copy link
Collaborator

Found some issues and talked in person. Waiting for the approval from @robot9706 side.

Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot9706 robot9706 merged commit 0f7570d into develop Oct 25, 2022
@robot9706 robot9706 deleted the feat/product-templates branch October 25, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:golang lang:typescript pr:feat source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants