Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): quality assurance #874

Merged
merged 17 commits into from
Nov 28, 2023
Merged

feat(web): quality assurance #874

merged 17 commits into from
Nov 28, 2023

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Oct 31, 2023

  • Add posthog for quality assurance purposes.
  • Add captures for common elements.
  • Add env variables for disable QA.

@m8vago m8vago requested a review from a team as a code owner October 31, 2023 14:25
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:typescript lang:sql pr:feat labels Oct 31, 2023
robot9706
robot9706 reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, haven't tested it yet.

web/crux-ui/src/components/projects/versions/deployments/deployment-view-list.tsx Outdated Show resolved Hide resolved
web/crux-ui/src/elements/dyo-button.tsx Outdated Show resolved Hide resolved
@m8vago m8vago changed the title feat(web): add posthog feat(web): add quality assurance Nov 6, 2023
@m8vago m8vago changed the title feat(web): add quality assurance feat(web): quality assurance Nov 6, 2023
@github-actions github-actions bot added source:cli The scope of the issue or pull request is CLI tool. lang:golang labels Nov 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023 •
edited

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8e63a51) 26.14% compared to head (0db4167) 26.14%.

Files Patch % Lines
golang/pkg/cli/container_defaults.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #874      +/-   ##
===========================================
- Coverage    26.14%   26.14%   -0.01%     
===========================================
  Files           70       70              
  Lines         7438     7440       +2     
===========================================
  Hits          1945     1945              
- Misses        5339     5341       +2     
  Partials       154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerimate
Copy link
Contributor

gerimate commented Nov 8, 2023

Can you please add this link directing to the docs pls?

polaroi8d
polaroi8d requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think it's not QA, it's Analytics.

web/crux-ui/src/elements/dyo-link.tsx Show resolved Hide resolved
web/crux-ui/src/hooks/use-posthog.ts Show resolved Hide resolved
@m8vago m8vago merged commit 086da74 into develop Nov 28, 2023
26 checks passed
@m8vago m8vago deleted the feat/quality-assurance branch November 28, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robot9706 robot9706 robot9706 approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@m8vago m8vago

Labels
lang:golang lang:sql lang:typescript pr:feat source:cli The scope of the issue or pull request is CLI tool. source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@m8vago @codecov-commenter @gerimate @robot9706 @polaroi8d