Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crux-ui): password show icon #882

Merged

Conversation

chandhuDev
Copy link
Contributor

@chandhuDev chandhuDev requested a review from a team as a code owner November 8, 2023 17:19
@chandhuDev chandhuDev changed the title Feat/password show icon feat(crux-ui):password show icon Nov 8, 2023
@polaroi8d
Copy link
Collaborator

@chandhuDev please do not close a PR and open a new, it's spamming our repository. (Regarding to this: #876 it should have been done first, please don't do this again.)

Problems with this PR:

web/crux-ui/src/elements/dyo-input.tsx Outdated Show resolved Hide resolved
@chandhuDev chandhuDev changed the title feat(crux-ui):password show icon feat(crux-ui): password show icon Nov 9, 2023
@polaroi8d polaroi8d linked an issue Nov 9, 2023 that may be closed by this pull request
@m8vago
Copy link
Contributor

m8vago commented Nov 27, 2023

Hi @chandhuDev

Thank you for the contribution!

Please run npm run format in both the web/crux and the web/crux-ui folders.

@m8vago m8vago changed the base branch from develop to feat/password-show-icon December 1, 2023 12:33
@m8vago m8vago merged commit 6bf332c into dyrector-io:feat/password-show-icon Dec 1, 2023
41 of 42 checks passed
m8vago pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add show password icon to password input fields
3 participants