Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crux-ui): hide change credentials field when creating a registry or a storage #893

Merged
merged 1 commit into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,16 @@ const GithubRegistryFields = (props: EditRegistryTypeProps<EditableGithubRegistr
message={errors.imageNamePrefix}
/>

<DyoToggle
className="mt-8"
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
{editing && (
<DyoToggle
className="mt-8"
disabled={!editing}
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
)}

{values.changeCredentials && (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,16 @@ const GitlabRegistryFields = (props: EditRegistryTypeProps<EditableGitlabRegistr
</>
)}

<DyoToggle
className="mt-8"
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
{editing && (
<DyoToggle
className="mt-8"
disabled={!editing}
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
)}

{values.changeCredentials && (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,16 @@ const GoogleRegistryFields = (props: EditRegistryTypeProps<EditableGoogleRegistr

{!values.public && (
<>
<DyoToggle
className="mt-8"
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
{editing && (
<DyoToggle
className="mt-8"
disabled={!editing}
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
)}

{values.changeCredentials && (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,16 @@ const HubRegistryFields = (props: EditRegistryTypeProps<EditableHubRegistryDetai

{!values.public && (
<>
<DyoToggle
className="mt-8"
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
{editing && (
<DyoToggle
className="mt-8"
disabled={!editing}
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
)}

{values.changeCredentials && (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,16 @@ const V2RegistryFields = (props: EditRegistryTypeProps<EditableV2RegistryDetails

{!values.public && (
<>
<DyoToggle
className="mt-8"
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
{editing && (
<DyoToggle
className="mt-8"
disabled={!editing}
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
)}

{values.changeCredentials && (
<>
Expand Down
17 changes: 10 additions & 7 deletions web/crux-ui/src/components/storages/edit-storage-card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,16 @@ const EditStorageCard = (props: EditStorageCardProps) => {

{!values.public && (
<>
<DyoToggle
className="mt-8"
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
{editing && (
<DyoToggle
className="mt-8"
disabled={!editing}
name="changeCredentials"
label={t('common:changeCredentials')}
checked={values.changeCredentials}
setFieldValue={formikSetFieldValueOrIgnore(formik, !editing)}
/>
)}

{values.changeCredentials && (
<>
Expand Down
Loading