Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add image push and pull to notifications #897

Merged
merged 9 commits into from
Jan 15, 2024

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Dec 21, 2023

Add new notification types:

  • Image push
  • Image pull

Add an option for creating jwt tokens for v2 registries, so we can receive notifications from them.

@m8vago m8vago requested a review from a team as a code owner December 21, 2023 20:51
@m8vago m8vago marked this pull request as draft December 21, 2023 20:51
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:typescript lang:sql and removed pr:feat labels Dec 21, 2023
@m8vago m8vago marked this pull request as ready for review January 9, 2024 14:59
@m8vago m8vago force-pushed the feat/registry-notifications branch from 4b1baff to e6714da Compare January 9, 2024 15:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 174 lines in your changes are missing coverage. Please review.

Comparison is base (5dca884) 18.95% compared to head (df2eda4) 12.56%.

Files Patch % Lines
web/crux/src/app/registry/registry.service.ts 0.00% 34 Missing ⚠️
web/crux/src/app/registry/registry.dto.ts 0.00% 23 Missing ⚠️
.../app/registry/guards/registry.team-access.guard.ts 0.00% 16 Missing ⚠️
web/crux/src/app/registry/registry.jwt.strategy.ts 0.00% 16 Missing ⚠️
.../crux/src/app/registry/registry.http.controller.ts 0.00% 13 Missing ⚠️
web/crux/src/guards/custom.jwt-auth.guard.ts 0.00% 13 Missing ⚠️
web/crux/src/domain/registry-token.ts 0.00% 11 Missing ⚠️
...src/app/registry/guards/registry.jwt-auth.guard.ts 0.00% 9 Missing ⚠️
...b/crux/src/app/notification/notification.mapper.ts 0.00% 8 Missing ⚠️
.../crux/src/app/notification/notification.service.ts 0.00% 6 Missing ⚠️
... and 9 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #897      +/-   ##
===========================================
- Coverage    18.95%   12.56%   -6.39%     
===========================================
  Files          324      257      -67     
  Lines        16531     9063    -7468     
  Branches       966      975       +9     
===========================================
- Hits          3133     1139    -1994     
+ Misses       13210     7899    -5311     
+ Partials       188       25     -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

web/crux-ui/locales/en/registries.json Outdated Show resolved Hide resolved
web/crux-ui/locales/en/registries.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey for me, pleas @robot9706 if you have time check it please.

Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sesms fine to me, but couldn't test it. One comment on the migration though.

@m8vago m8vago force-pushed the feat/registry-notifications branch from 1c54685 to bff5954 Compare January 12, 2024 15:02
@m8vago m8vago force-pushed the feat/registry-notifications branch from bff5954 to 29a71c1 Compare January 12, 2024 15:02
@m8vago m8vago merged commit c654491 into develop Jan 15, 2024
26 checks passed
@m8vago m8vago deleted the feat/registry-notifications branch January 15, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:sql lang:typescript pr:feat source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants