Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): pipeline event watchers #905

Merged
merged 7 commits into from
Jan 31, 2024
Merged

feat(web): pipeline event watchers #905

merged 7 commits into from
Jan 31, 2024

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Jan 30, 2024

  • Add automatic pipeline triggers based on registry push events

@m8vago m8vago requested a review from a team as a code owner January 30, 2024 10:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 186 lines in your changes are missing coverage. Please review.

Comparison is base (b16a13e) 18.22% compared to head (8c6f667) 11.87%.

Files Patch % Lines
web/crux/src/app/pipeline/pipeline.service.ts 0.00% 53 Missing ⚠️
web/crux/src/app/pipeline/pipeline.dto.ts 0.00% 25 Missing ⚠️
web/crux/src/domain/pipeline.ts 0.00% 23 Missing ⚠️
web/crux/src/app/pipeline/pipeline.mapper.ts 0.00% 22 Missing ⚠️
web/crux/src/app/registry/registry.service.ts 0.00% 20 Missing ⚠️
.../crux/src/app/pipeline/pipeline.http.controller.ts 0.00% 14 Missing ⚠️
.../crux/src/app/registry/registry-client.provider.ts 0.00% 8 Missing ⚠️
...rux/src/app/registry/registry-clients/v2-labels.ts 0.00% 6 Missing ⚠️
...b/crux/src/services/domain.notification.service.ts 50.00% 5 Missing ⚠️
web/crux/src/app/registry/registry.dto.ts 0.00% 3 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #905      +/-   ##
===========================================
- Coverage    18.22%   11.87%   -6.35%     
===========================================
  Files          344      274      -70     
  Lines        17118     9673    -7445     
  Branches      1006     1013       +7     
===========================================
- Hits          3120     1149    -1971     
+ Misses       13810     8499    -5311     
+ Partials       188       25     -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, haven't tested it though.

@polaroi8d
Copy link
Collaborator

crux build is failing

@m8vago
Copy link
Contributor Author

m8vago commented Jan 31, 2024

crux build is failing

Thanks! It was caused by the rebase. Now fixed.

@m8vago m8vago merged commit dc7e91a into develop Jan 31, 2024
26 checks passed
@m8vago m8vago deleted the feat/pipeline-events branch January 31, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:sql lang:typescript pr:feat source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants