Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): add missing i18n lines #909

Merged
merged 3 commits into from
Feb 14, 2024
Merged

fix(web): add missing i18n lines #909

merged 3 commits into from
Feb 14, 2024

Conversation

polaroi8d
Copy link
Collaborator

No description provided.

@polaroi8d polaroi8d requested a review from a team as a code owner February 14, 2024 09:18
@github-actions github-actions bot added the source:web The scope of the issue or pull request is web. label Feb 14, 2024
m8vago
m8vago requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@m8vago m8vago left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some lines with the old translation pattern:

  • line 166 in web/crux-ui/src/components/projects/versions/version-deployments-section.tsx
  • line 54 in web/crux-ui/src/components/nodes/node-deployment-list.tsx

@polaroi8d polaroi8d merged commit 96dccee into develop Feb 14, 2024
26 checks passed
@polaroi8d polaroi8d deleted the fix/i18n-deployment-statuses branch February 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robot9706 robot9706 robot9706 left review comments

@m8vago m8vago m8vago approved these changes

Assignees

@polaroi8d polaroi8d

Labels
lang:typescript pr:fix source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polaroi8d @m8vago @robot9706