Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crux): encryption key generation #914

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Feb 16, 2024

Fixes an issue, where one could not generate an encryption key without defining the ENCRYPTION_SECRET_KEY variable.

@m8vago m8vago requested a review from a team as a code owner February 16, 2024 11:15
@github-actions github-actions bot added pr:fix source:web The scope of the issue or pull request is web. lang:typescript lang:shell and removed pr:fix labels Feb 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f647aa4) 17.98% compared to head (0b308f7) 11.84%.

Files Patch % Lines
web/crux/src/config/app.config.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #914      +/-   ##
===========================================
- Coverage    17.98%   11.84%   -6.14%     
===========================================
  Files          345      274      -71     
  Lines        17406     9706    -7700     
  Branches      1020     1021       +1     
===========================================
- Hits          3130     1150    -1980     
+ Misses       14087     8531    -5556     
+ Partials       189       25     -164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nandor-magyar nandor-magyar merged commit 93dbef6 into develop Feb 16, 2024
6 checks passed
@nandor-magyar nandor-magyar deleted the fix/encryption-key-generation branch February 16, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:shell lang:typescript pr:fix source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants