-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/with level #399
Feature/with level #399
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new feature to handle parameter levels in the benchmarking process. The changes include modifications to the File-Level Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @blooop - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 8 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 90.01% 90.08% +0.06%
==========================================
Files 56 57 +1
Lines 3255 3277 +22
==========================================
+ Hits 2930 2952 +22
Misses 325 325 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
This pull request introduces support for parameter levels in sweeps, adds a new example demonstrating this feature, and updates existing functions and tests to accommodate the new functionality.
p
inbencher/variables/inputs.py
to create parameter dictionaries with optional max_level.example_levels2.py
demonstrating the use ofwith_level
for parameter sweeps.plot_sweep
andconvert_vars_to_params
functions to supportrun_cfg
and handle parameters with levels.example_custom_sweep2.py
to use the newp
function for defining input variables.test_example_level2
intest_bench_examples.py
to validate theexample_levels2
functionality.