Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated syntax @doc #15

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Conversation

femtotrader
Copy link
Contributor

@femtotrader femtotrader commented Oct 3, 2018

Fix deprecated syntax @doc
Format docstring as mentioned in https://github.com/JuliaDocs/Documenter.jl/blob/master/docs/src/man/guide.md#adding-some-docstrings

Closes #14

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   96.88%   96.88%           
=======================================
  Files           9        9           
  Lines         449      449           
=======================================
  Hits          435      435           
  Misses         14       14
Impacted Files Coverage Δ
src/mom.jl 98.91% <ø> (ø) ⬆️
src/run.jl 99.12% <ø> (ø) ⬆️
src/patterns.jl 100% <ø> (ø) ⬆️
src/reg.jl 100% <ø> (ø) ⬆️
src/ma.jl 94.52% <ø> (ø) ⬆️
src/utils.jl 100% <ø> (ø) ⬆️
src/vol.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e65b1a...63b3850. Read the comment docs.

@dysonance
Copy link
Owner

Thanks again for the help, looks good. Also appreciate the reference to the new documentation convention, wasn't aware of this style until now.

@dysonance dysonance merged commit 2ea2b7d into dysonance:master Oct 4, 2018
@femtotrader
Copy link
Contributor Author

My pleasure @dysonance ... could you have a look at your LinkedIn also for private discussion?

@dysonance
Copy link
Owner

@femtotrader Sure, just checked my LinkedIn, no new invites or messages. Should I be expecting something?

@femtotrader
Copy link
Contributor Author

Invite sent (again!!)... but you can also email me at https://femtotrader.github.io/ (see below)

@femtotrader
Copy link
Contributor Author

Invite sent (again!!) but it looks like as if you was refusing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants