Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme example to create CHRIS/ under data/ if it doesn't exist. #23

Merged
merged 1 commit into from Aug 26, 2019

Conversation

tkyn
Copy link
Contributor

@tkyn tkyn commented Aug 3, 2019

Running the original example code as is, for the first time, Temporal.tswrite(X, savedata_path) fails to create the downloaded csv file, because it tries to write to data/CHRIS/CME_CL1.csv when CHRIS/ subdirectoy does not (yet) exist. (Quandl id "CHRIS/CME_CL1 having "/" being the cause here.) This hack, sort of, fixes the above error. Alternatively, escaping '/'(slash) to something like '_"(underscore) maybe a better solution... Thanks Takehiro

@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #23 into master will increase coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage    63.5%   64.46%   +0.96%     
==========================================
  Files          12       12              
  Lines         200      197       -3     
==========================================
  Hits          127      127              
+ Misses         73       70       -3
Impacted Files Coverage Δ
src/compute/optimize.jl 90% <0%> (+4.28%) ⬆️
src/compute/backtest.jl 100% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1579c29...fd48c9d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.957% when pulling fd48c9d on tkyn:master into 1579c29 on dysonance:master.

@dysonance dysonance merged commit 96e7fb2 into dysonance:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants