-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with Julia 1.0v #17
Comments
A good way to know if a developer is alive (ie still active) is by submitting him pull request. |
I cloned the repository and tested the code on the 0.6.4v, yet, the code seems to be incompatible due to Indicator's being 0.6.0v only (That's what I took from the error I received), and there's no Windows binary for the older 0.6.0v release. So now I'm compilling that specific version to run it properly and port it to 1.0.0v as a pull request eventually. |
https://github.com/dysonance/Strategems.jl/blob/master/src/rule.jl#L15-L21 doesn't work with Julia 0.7. It raises
|
This seems similar to: |
Not sure if that's a correct fix or not: https://github.com/dysonance/Strategems.jl/pull/19/files#diff-a7f10850a9e8c4fb546b622a1813a813L19 |
Tests are passing with Julia 0.7 so:
|
I think that's the correct fix. The splat there is forcefully converting the variable to a possible array, whereas 0.7.0v does this conversion automatically when needed. This should result in a conflict that is resolved when you remove the (...), the question is, why that didn't happen with the other splats? Maybe they all were used as arrays and that specific variable didn't? Edit: I investigated further, and found that 0.7.0v supports direct specification of splatting interpolation: |
@VerifiedGruber @femtotrader Thanks for bringing this to light guys, looking into it now. Will review the PR changes and try to figure out what's required to get this working again. Also, my apologies for the lag in getting this package up to date with newer Julia versions. |
@VerifiedGruber @femtotrader Hey guys, just merged the above request to get this package working for current Julia versions. I've released a new version for these updates ( Closing this issue for now, let me know if you guys experience any more issues and we can continue making improvements. Thanks again for raising this issue, and thanks to @femtotrader for all the leg work he did to minimize the final steps required to get this done. Cheers guys. |
When installing the package, you're met with the following message:
The whole Git seems to have been deprecated, is the developer still active?
The text was updated successfully, but these errors were encountered: