-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future of this crate #15
Comments
Hi @flosse, Indeed there are some old dependencies here. I seem to have started using I have a plan to migrate to futures and tokio. I think the client can be migrated separately from the server, but it will take some time, as you mention. I am presently in the middle of some usability improvements around accessing and sending subscription and callback parameters. I'm very willing to collaborate. @zrneely may have different goals than mine, or want to take a different approach, but I'll let him weigh in on that. Looking at his crate, the style of the client seems pretty close to the approach I'd migrate the client to. To summarize, my plan is to keep working slowly on wamp-rs, and I'd gladly welcome contributions. |
I'm glad to read this :) |
Hey everyone, sorry for the late reply! I did indeed start my wamp-proto project a while ago, but it's nowhere near usable. I'm still working through some of the design decisions - it's tricky to deal with out-of-order messages with tokio/futures (especially since this is my first tokio project) :) Unfortunately I haven't worked on it in a while, although I'd love to be more active with it and/or collaborate in some form, although again I'm not quite sure how that would work. |
Hey @zrneely, my thought for collaboration is this: basically the entire client for wamp-rs is in a single file. I believe, from reading your code, that it could be wholesale replaced by the client code that you are writing, with only some small changes. Basically, I think if you used my Value instead of TransportValue and my Message enum in place of your Message trait, your library would be compatible with mine, and therefore gain the entire router component alongside the testing and examples I've already done. |
This crates is somewhat outdated. It uses the deprecated
eventual
crate that was replaced byfutures
andtokio
. There is a lot of work to be done to shift it to modern state where it can be used with e.g.tokio v0.1
(ortokio v0.2
soon).Moreover it depends directly on
ws
whereas a transport abstraction would be great.@zrneely started a new project called wamp-proto but its not ready yet.
Instead of maintaining/developing two crates that do the same thing I think it makes sense to combine the efforts.
So @dyule what is your plan within the near future with
wamp-rs
?The text was updated successfully, but these errors were encountered: