-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate_df
implementation to ADLSToAzureSQL
#834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this function here? It was created to prevent uploading incorrect data (files) to ADLS. We have this function 'active' for each viadot source. What is the reason for putting this function here? It is the next step ADLS->DB
Please add a new parameter to tests.
implementation to
ADLSToAzureSQL`
implementation to
ADLSToAzureSQL`validate_df
implementation to ADLSToAzureSQL
Please resolve conflict |
Done |
Added tes for validate_df param ✅ Added tests for validate_df param |
Looks good, please add information to the Changelog that a new parameter was added to |
Changed CHANGELOG.md file |
Summary
Added validate_df func into ADLSToAzureSQL flow for potential test on level ADLS-to-AzureSQL
Importance
Genesys connector needs validation on this level of data flow
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md