fix(user): return paginated user list on users endpoint (#283)

dzangolab · Mar 29, 2023 · 00954dc · 00954dc
1 parent 4ce0514
commit 00954dc
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/packages/user/src/__test__/resolver.spec.ts b/packages/user/src/__test__/resolver.spec.ts
@@ -12,12 +12,12 @@ import type { MercuriusContext } from "mercurius";
 import type { Mock } from "vitest";
 
 const findById = vi.fn();
-const list = vi.fn();
+const paginatedList = vi.fn();
 
 vi.mock("../model/user-profiles/service", () => ({
   default: class UserProfileService {
     findById = findById;
-    list = list;
+    paginatedList = paginatedList;
   },
 }));
 
@@ -38,7 +38,7 @@ describe("user service resolver", () => {
     expect(findById).toBeCalledWith(id);
   });
 
-  it("Should call the UserProfileService list method with proper limit and offset values", async () => {
+  it("Should call the UserProfileService paginatedList method with proper limit and offset values", async () => {
     const count = 190;
 
     const dataset = await getLimitAndOffsetDataset(count, createConfig());
@@ -48,8 +48,15 @@ describe("user service resolver", () => {
 
       if (limit && offset) {
         resolver.Query.users(undefined, { limit, offset }, context);
-        /* eslint-disable-next-line unicorn/no-useless-undefined */
-        expect(list).toBeCalledWith(limit, offset, undefined, undefined);
+
+        expect(paginatedList).toBeCalledWith(
+          limit,
+          offset,
+          /* eslint-disable-next-line unicorn/no-useless-undefined */
+          undefined,
+          /* eslint-disable-next-line unicorn/no-useless-undefined */
+          undefined
+        );
       }
     }
   });

diff --git a/packages/user/src/model/user-profiles/controller.ts b/packages/user/src/model/user-profiles/controller.ts
@@ -25,7 +25,7 @@ const plugin = async (
         sort?: string;
       };
 
-      const data = await service.list(
+      const data = await service.paginatedList(
         limit,
         offset,
         filters ? JSON.parse(filters) : undefined,

diff --git a/packages/user/src/model/user-profiles/resolver.ts b/packages/user/src/model/user-profiles/resolver.ts
@@ -27,7 +27,7 @@ const Query: Record<string, any> = {
   ) => {
     const service = new Service(context.config, context.database);
 
-    return await service.list(
+    return await service.paginatedList(
       arguments_.limit,
       arguments_.offset,
       arguments_.filters