feat(slonik): change slonik.migrations config type (#115)

dzangolab · Dec 21, 2022 · f8b0abf · f8b0abf
1 parent 49975c6
commit f8b0abf
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 15 deletions.
diff --git a/packages/slonik/README.md b/packages/slonik/README.md
@@ -9,7 +9,6 @@ The plugin also includes logic to run migrations via [`postgres-migrations`](htt
 # Requirements
 
 * @dzangolab/fastify-config
-* postgres-migrations
 * slonik
 
 
@@ -18,13 +17,13 @@ The plugin also includes logic to run migrations via [`postgres-migrations`](htt
 In a simple repo:
 
 ```bash
-npm install @dzangolab/fastify-slonik slonik postgres-migrations
+npm install @dzangolab/fastify-slonik slonik
 ```
 
 If using in a monorepo with pnpm:
 
 ```bash
-pnpm add --filter "myrepo" @dzangolab/fastify-slonik slonik postgres-migrations
+pnpm add --filter "myrepo" @dzangolab/fastify-slonik slonik
 ```
 
 ## Usage

diff --git a/packages/slonik/package.json b/packages/slonik/package.json
@@ -22,7 +22,8 @@
     "typecheck": "tsc --noEmit -p tsconfig.json --composite false"
   },
   "dependencies": {
-    "fastify-slonik": "2.0.0"
+    "fastify-slonik": "2.0.0",
+    "postgres-migrations": "5.3.0"
   },
   "devDependencies": {
     "@dzangolab/fastify-config": "0.10.8",
@@ -33,7 +34,6 @@
     "eslint-config-custom": "0.10.8",
     "fastify": "4.10.2",
     "fastify-plugin": "4.4.0",
-    "postgres-migrations": "5.3.0",
     "prettier": "2.8.1",
     "slonik": "30.3.1",
     "tsconfig": "0.10.8",
@@ -44,7 +44,6 @@
     "@dzangolab/fastify-config": "0.10.8",
     "fastify": ">=4.9.2",
     "fastify-plugin": ">=4.3.0",
-    "postgres-migrations": ">=5.3.0",
     "slonik": ">=30.3.1"
   },
   "engines": {

diff --git a/packages/slonik/src/migrate.ts b/packages/slonik/src/migrate.ts
@@ -23,13 +23,7 @@ const migrate = async (config: ApiConfig) => {
     defaultDatabase: "postgres",
   } as MigrateDBConfig;
 
-  let migrationsPath = slonikConfig.migrations.development;
-
-  if (config.env === "production") {
-    migrationsPath = slonikConfig.migrations.production;
-  }
-
-  await runMigrations(dbConfig, migrationsPath);
+  await runMigrations(dbConfig, slonikConfig.migrations.path);
 };
 
 export default migrate;
diff --git a/packages/slonik/src/types.ts b/packages/slonik/src/types.ts
@@ -10,8 +10,7 @@ type Database = {
 type SlonikConfig = {
   db: ConnectionOptions;
   migrations: {
-    development: string;
-    production: string;
+    path: string;
   };
 };