Crash when deallocating

[guilhermearaujo]

I am trying to use this Control on a Storyboard. My view controller is arranged this way:
UIViewController > UIView (Main) > UIView (Gradient BG) > UIView (DZNSegmentedControl)

If I push that view controller and then pop it, the app crashes with this log message (note: zombies enabled):

*** -[UIView release]: message sent to deallocated instance 0x7fedeae64ac0

If I remove the class name from that view, the app will no longer crash.
If the view assigned as DZNSegmentedControl is not inside a second view (the gradient), but is inside the main view, it also will not crash.

I created a sample project that demonstrates this.
The project has a second branch called programmatically, when I keep the inner view set as a regular UIView and then add a DZNSegmentedControl inside it programmatically. that way the app will not crash.

[SofteqDG]

You need to check newSuperview in the willMoveToSuperview method to fix this issue.
This fix works for me

- (void)willMoveToSuperview:(UIView *)newSuperview
{
    [super willMoveToSuperview:newSuperview];

    if (newSuperview) {

        [self layoutIfNeeded];
    }
}

[dzenbot]

👍 this crash isn't really related to DZNSegmentedControl code tho, is it?

[SofteqDG]

This fix is for willMoveToSuperview method of the DZNSegmentedControl.
I really don't know why DZNSegmentedControl crashes without this check (maybe system issue?)
But it is logical that not necessary to call layoutIfNeeded method if newSuperview is nil :)

[dzenbot]

What if we override layoutIfNeeded and added this following implementation:

- (void)layoutIfNeeded
{
    if (!self.superview) {
        return;
    }

    [super layoutIfNeeded];
}

Do you think that would solve it?

[dzenbot]

Based on the documentation:

A view object that will be the new superview of the receiver. This object may be nil.

So your fix it pretty much legit. I looks like willMoveToSuperview: is still called when removing from superview.