Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user when using "_" instead of "-" in iconNames #299

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

dzhuang
Copy link
Owner

@dzhuang dzhuang commented Jun 10, 2023

Summary

Proposed changes

This PR brings the following changes:

  • Warn user when using _ instead of - in iconNames

Related issue

#229 #298


Testing

  • I have added or updated tests that prove my fix is effective or that my feature works (if applicable)
    • Unit test
    • Snapshot test
    • Manual test

Checklist

  • I have added corresponding labels to this PR (like bug, enhancement...);
  • My commits follow the Conventional Commits 1.0 Guidelines;
  • My code follows the style guidelines of this project;
  • I have performed a self-review of my own code;
  • I have mapped technical debts found on my changes;
  • I have made changes to the documentation (if applicable);
  • My changes generate no new warnings or errors;

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (6df7aa1) 94.50% compared to head (e2d8c22) 94.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   94.50%   94.53%   +0.02%     
==========================================
  Files          16       16              
  Lines         764      768       +4     
  Branches      133      135       +2     
==========================================
+ Hits          722      726       +4     
  Misses         18       18              
  Partials       24       24              
Impacted Files Coverage Δ
src/providers/base.ts 87.24% <100.00%> (+0.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dzhuang dzhuang added the enhancement New feature or request label Jun 10, 2023
@dzhuang dzhuang closed this Jun 10, 2023
@dzhuang dzhuang reopened this Jun 10, 2023
@dzhuang dzhuang merged commit 9559170 into main Jun 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants