New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Auth and Session backends #9
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what I changed but now the sessions don't get saved in redis.
Conflicts: snaplet-redis.cabal
configurator >= 0.2 && < 0.4, | ||
containers >= 0.5.0.0, | ||
hedis == 0.6.*, | ||
lens >= 3.8 && < 4.4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump lens
@AshyIsMe Are you still interested in merging this? |
@imalsogreg I haven't used (or tested) this in a long time so it's up to you if you want to take on the maintenance burden, otherwise feel free to close it. |
Moving to #13 |
dzhus
pushed a commit
that referenced
this pull request
Sep 5, 2017
Originally contributed by Aaron Ash <aaron.ash@gmail.com> #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Redis backed Auth and Session backends.
Implemented the recommendations you made from the previous pull request.
Feel free to make a bunch more recommendations if you see further changes you would like.
Cheers,
Aaron.